Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm setPackageVersion semver2 support #236

Closed
cdunford opened this issue Oct 22, 2018 · 2 comments
Closed

npm setPackageVersion semver2 support #236

cdunford opened this issue Oct 22, 2018 · 2 comments
Assignees
@AArnott
Milestone
2.3

Comments

@cdunford
Copy link
Contributor

setPackageVersion is a nice helper function to update the version in a package.json file. Today it looks like it will always spit out a semver1 version. It would be nice if it could be parameterized to support semver2, as npm as semver2 support.
@cdunford cdunford mentioned this issue Oct 22, 2018
Closed
@AArnott AArnott self-assigned this Nov 25, 2018
@AArnott AArnott added this to the 2.3 milestone Nov 25, 2018
@AArnott
Copy link
Collaborator

AArnott commented Nov 25, 2018

Does NPM support semver2 consistently everywhere, or should it be an option for folks to use semver1 or 2? And which should be the default.

@AArnott
Copy link
Collaborator

AArnott commented Nov 25, 2018

I'm finding semver2 usage as far back as six years ago here (history page). So it sure seems like semver2 should be the default (and in fact only) option.

AArnott added a commit that referenced this issue Nov 25, 2018
@AArnott
Use SemVer 2.0 for NPM packages
34ceaf3 
This has been around and supported for at least six years in NPM.

Fixes #236
@AArnott AArnott mentioned this issue Nov 25, 2018
Merged
AArnott added a commit that referenced this issue Nov 25, 2018
@AArnott
Use SemVer 2.0 for NPM packages
9db531a 
This has been around and supported for at least six years in NPM.

Fixes #236
AArnott added a commit that referenced this issue Apr 1, 2024
@AArnott
Merge pull request #236 from AArnott/removedotnet-format
27eb2a1 
Remove `dotnet-format` as a tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Add semver2 support to npm
2 participants
@AArnott @cdunford