Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benign warnings #1082

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix benign warnings #1082

merged 1 commit into from
Dec 6, 2024

Conversation

dorssel
Copy link
Owner

@dorssel dorssel commented Dec 6, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 9 0 0.03s
✅ BASH bash-exec 1 0 0.0s
✅ BASH shellcheck 1 0 0.05s
✅ BASH shfmt 1 0 0.0s
✅ EDITORCONFIG editorconfig-checker 162 0 0.54s
✅ JSON jsonlint 4 0 0.16s
✅ JSON prettier 3 0 0.39s
✅ JSON v8r 4 0 3.68s
✅ MARKDOWN markdownlint 3 0 0.43s
✅ MARKDOWN markdown-link-check 3 0 7.17s
✅ MARKDOWN markdown-table-formatter 3 0 0.2s
✅ REPOSITORY checkov yes no 13.11s
✅ REPOSITORY gitleaks yes no 3.2s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY grype yes no 15.59s
✅ REPOSITORY secretlint yes no 1.04s
✅ REPOSITORY trivy-sbom yes no 0.18s
✅ REPOSITORY trufflehog yes no 5.39s
✅ XML xmllint 17 0 0.02s
✅ YAML prettier 14 0 0.88s
✅ YAML v8r 14 0 19.39s
✅ YAML yamllint 14 0 0.4s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

2 938 tests  ±0   2 938 ✅ ±0   9s ⏱️ ±0s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fd5dfec. ± Comparison against base commit 7402f09.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.
UnitTests.Parse_policy_Tests ‑ add_BothSuccess
UnitTests.Parse_policy_Tests ‑ add_BusIdSuccess
UnitTests.Parse_policy_Tests ‑ add_HardwareIdSuccess
UnitTests.Parse_policy_Tests ‑ add_MissingCondition
UnitTests.Parse_policy_Tests ‑ list_Help
UnitTests.Parse_policy_Tests ‑ list_OptionInvalid
UnitTests.Parse_policy_Tests ‑ list_StrayArgument
UnitTests.Parse_policy_Tests ‑ list_Success
UnitTests.Parse_policy_Tests ‑ remove_AllSuccess
UnitTests.Parse_policy_Tests ‑ remove_GuidSuccess
…
UnitTests.Parse_policy_Tests ‑ Add_BothSuccess
UnitTests.Parse_policy_Tests ‑ Add_BusIdSuccess
UnitTests.Parse_policy_Tests ‑ Add_HardwareIdSuccess
UnitTests.Parse_policy_Tests ‑ Add_MissingCondition
UnitTests.Parse_policy_Tests ‑ List_Help
UnitTests.Parse_policy_Tests ‑ List_OptionInvalid
UnitTests.Parse_policy_Tests ‑ List_StrayArgument
UnitTests.Parse_policy_Tests ‑ List_Success
UnitTests.Parse_policy_Tests ‑ Remove_AllSuccess
UnitTests.Parse_policy_Tests ‑ Remove_GuidSuccess
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 66 lines in your changes missing coverage. Please review.

Project coverage is 40.44%. Comparing base (7402f09) to head (fd5dfec).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Usbipd/ConfigurationManager.cs 0.00% 22 Missing ⚠️
Usbipd/Wsl.cs 0.00% 12 Missing ⚠️
Usbipd/NewDev.cs 0.00% 10 Missing ⚠️
Usbipd/ConnectedClient.cs 0.00% 8 Missing ⚠️
Usbipd/AttachedEndpoint.cs 0.00% 6 Missing ⚠️
Usbipd/AttachedClient.cs 0.00% 4 Missing ⚠️
Usbipd/VBoxUsb.cs 0.00% 2 Missing ⚠️
Usbipd/DeviceFile.cs 50.00% 0 Missing and 1 partial ⚠️
Usbipd/RequestReply.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
- Coverage   40.81%   40.44%   -0.38%     
==========================================
  Files          38       38              
  Lines        3033     3066      +33     
  Branches      499      499              
==========================================
+ Hits         1238     1240       +2     
- Misses       1749     1780      +31     
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorssel dorssel enabled auto-merge December 6, 2024 07:54
@dorssel dorssel merged commit 8b047d4 into master Dec 6, 2024
10 checks passed
@dorssel dorssel deleted the editorconfig branch December 6, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant