Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Khronos samples broken by quantization #330

Closed
donmccurdy opened this issue Aug 17, 2021 · 4 comments
Closed

Various Khronos samples broken by quantization #330

donmccurdy opened this issue Aug 17, 2021 · 4 comments
Labels
bug Something isn't working package:functions
Milestone

Comments

@donmccurdy
Copy link
Owner

Examples:

  • BoxTextured
  • BrainStem
  • CesiumMan
  • MorphStressTest
  • DragonAttenuation
  • RiggedFigure
  • RiggedSimple
  • TextureSettingsTest
  • TextureTransformMultiTest

Screen Shot 2021-08-16 at 6 22 39 PM
Screen Shot 2021-08-16 at 6 22 16 PM
Screen Shot 2021-08-16 at 5 45 50 PM
Screen Shot 2021-08-16 at 6 21 31 PM
Screen Shot 2021-08-16 at 6 21 11 PM
Screen Shot 2021-08-16 at 6 20 02 PM

@donmccurdy donmccurdy added bug Something isn't working package:functions labels Aug 17, 2021
@donmccurdy donmccurdy added this to the v0.12 milestone Aug 17, 2021
@donmccurdy
Copy link
Owner Author

Volume attenuation distance is a distinct problem, already reported at mrdoob/three.js#22343.

The rest — particularly texture settings, skinning, and morph targets — are likely to represent bugs in the quantize() function implemented here.

@donmccurdy
Copy link
Owner Author

donmccurdy commented Aug 20, 2021

Many issues fixed in #333.

A few remaining:

@donmccurdy
Copy link
Owner Author

Not a bug, but quantization currently skips any texture coordinates extending beyond the [0,1] range. Could improve completeness by quantizing, adding KHR_texture_transform when those are encountered.

@donmccurdy
Copy link
Owner Author

Closing this and filing the remaining tasks as new issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:functions
Projects
None yet
Development

No branches or pull requests

1 participant