Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinimalStyle #606

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Add MinimalStyle #606

merged 2 commits into from
Jun 17, 2022

Conversation

davidanthoff
Copy link
Contributor

@domluna does that look right to you? It is meant to give users the same defaults that they get if they use VS Code right now to format things.

CC @pfitzseb

Copy link
Owner

@domluna domluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this looks good

@@ -5,5 +5,5 @@ function _precompile_()
Base.precompile(Tuple{typeof(pretty),DefaultStyle,CSTParser.EXPR,State})
Base.precompile(Tuple{typeof(pretty),YASStyle,CSTParser.EXPR,State})
Base.precompile(Tuple{typeof(pretty),BlueStyle,CSTParser.EXPR,State})

Base.precompile(Tuple{typeof(pretty),MinimalStyle,CSTParser.EXPR,State})
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know if this is necessary, unclear if this precompile file is doing anything useful at this point

@davidanthoff
Copy link
Contributor Author

Ok, I think ready to merge?

@domluna domluna merged commit 5f2cc86 into domluna:master Jun 17, 2022
@davidanthoff davidanthoff deleted the minimal-style branch June 17, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants