Separate CLI and nodeAPI

[tommytroylin]

In our project we use webpack to bundle all js files into a single one.

The first issue is that there is #! /usr/bin/env node at the top of index.js. It will cause an error when webpack tries to resolve this module. And This issue is solved by adding a loader to remove that piece of code.
The second is Error: rc(name): name *must* be a string

When we actually running the bundled code. We got that error. After digging the source code, we find errors happened here

It seems like when this module is running from cli, it will output something to console.
But in webpack bundle, module.parent is not implemented.
And proccess.argv[2] is undefined in this case.

Now we simply remove that console.log and everything works fine.

This PR solves these 2 issues together.

[dominictarr]

that is a bug in webpack, webpack/webpack#2168

[tommytroylin]

@dominictarr
I understand.
The #! issue is a webpack bug and we actually fixed that by adding a new loader.

But the second issue is a bit annoying, and I hope it can be fixed in the next release since we need to modify the source code manually now.

Thank you in advance.

[chabou]

Please merge this PR 🙏

First issue can be fixed with this webpack workaround (using shebang-loader):

{
  test: /index.js/,
  loader: 'shebang-loader',
  include: [/node_modules\/rc/]
}

But we can't do anything for this console output 😞

I really need this PR to be merged to use npm-name in a webpacked cli tool.

[rauchg]

This PR makes a lot of sense! I would merge it.

[chabou]

@dominictarr Is there a chance to have this PR merged soon? 🙏

[dominictarr]

reluctantly merged this into 1.2.3
once upon a time this just worked in browserify, but now neither browserify or webpack support this by default so people end up posting issues all the time!

[chabou]

Thank you so much!