Library - Add 16-128k IoBatch/EventResult pool for read and write

Most read & write in the real world are made with 4-128k buffers. Adding pools for those sizes avoids the repetitive alloc and free cost.
dokan-dev · Feb 13, 2022 · a04b410 · a04b410
1 parent cf3ee14
commit a04b410
Show file tree

Hide file tree

Showing 15 changed files with 351 additions and 34 deletions.
diff --git a/dokan/cleanup.c b/dokan/cleanup.c
@@ -25,7 +25,8 @@ with this program. If not, see <http://www.gnu.org/licenses/>.
 VOID DispatchCleanup(PDOKAN_IO_EVENT IoEvent) {
   CheckFileName(IoEvent->EventContext->Operation.Cleanup.FileName);
 
-  CreateDispatchCommon(IoEvent, 0, /*ClearBuffer=*/TRUE);
+  CreateDispatchCommon(IoEvent, 0, /*UseExtraMemoryPool=*/FALSE,
+                       /*ClearNonPoolBuffer=*/TRUE);
 
   IoEvent->EventResult->Status = STATUS_SUCCESS; // return success at any case
 

diff --git a/dokan/create.c b/dokan/create.c
@@ -120,7 +120,8 @@ VOID DispatchCreate(PDOKAN_IO_EVENT IoEvent) {
 
   CheckFileName(fileName);
 
-  CreateDispatchCommon(IoEvent, 0, /*ClearBuffer=*/TRUE);
+  CreateDispatchCommon(IoEvent, 0, /*UseExtraMemoryPool=*/FALSE,
+                       /*ClearNonPoolBuffer=*/TRUE);
 
   assert(IoEvent->DokanOpenInfo == NULL);
 

diff --git a/dokan/directory.c b/dokan/directory.c
@@ -635,7 +635,8 @@ VOID DispatchDirectoryInformation(PDOKAN_IO_EVENT IoEvent) {
 
   CreateDispatchCommon(IoEvent,
                        IoEvent->EventContext->Operation.Directory.BufferLength,
-                       /*ClearBuffer=*/TRUE);
+                       /*UseExtraMemoryPool=*/FALSE,
+                       /*ClearNonPoolBuffer=*/TRUE);
 
   IoEvent->EventResult->Operation.Directory.Index =
       IoEvent->EventContext->Operation.Directory.FileIndex;

diff --git a/dokan/dokan.c b/dokan/dokan.c
@@ -376,10 +376,23 @@ VOID HandleProcessIoFatalError(PDOKAN_INSTANCE DokanInstance,
   OnDeviceIoCtlFailed(DokanInstance, Result);
 }
 
-VOID FreeIoEventResult(PEVENT_INFORMATION EventResult, BOOL PoolAllocated) {
+VOID FreeIoEventResult(PEVENT_INFORMATION EventResult, ULONG EventResultSize,
+                       BOOL PoolAllocated) {
   if (EventResult) {
     if (PoolAllocated) {
-      PushEventResult(EventResult);
+      if (EventResultSize <= DOKAN_EVENT_INFO_DEFAULT_SIZE) {
+        PushEventResult(EventResult);
+      } else if (EventResultSize <= DOKAN_EVENT_INFO_16K_SIZE) {
+        Push16KEventResult(EventResult);
+      } else if (EventResultSize <= DOKAN_EVENT_INFO_32K_SIZE) {
+        Push32KEventResult(EventResult);
+      } else if (EventResultSize <= DOKAN_EVENT_INFO_64K_SIZE) {
+        Push64KEventResult(EventResult);
+      } else if (EventResultSize <= DOKAN_EVENT_INFO_128K_SIZE) {
+        Push128KEventResult(EventResult);
+      } else {
+        assert(FALSE);
+      }
     } else {
       FreeEventResult(EventResult);
     }
@@ -419,11 +432,13 @@ DWORD SendAndPullEventInformation(PDOKAN_IO_EVENT IoEvent,
   DWORD lastError = 0;
   PCHAR inputBuffer = NULL;
   DWORD eventInfoSize = 0;
+  ULONG eventResultSize = 0;
   PEVENT_INFORMATION eventInfo = NULL;
   BOOL eventInfoPollAllocated = FALSE;
 
   if (IoEvent && IoEvent->EventResult) {
     eventInfo = IoEvent->EventResult;
+    eventResultSize = IoEvent->EventResultSize;
     eventInfoPollAllocated = IoEvent->PoolAllocated;
     inputBuffer = (PCHAR)eventInfo;
     eventInfoSize =
@@ -455,7 +470,7 @@ DWORD SendAndPullEventInformation(PDOKAN_IO_EVENT IoEvent,
           )) {
     lastError = GetLastError();
     if (eventInfo) {
-      FreeIoEventResult(eventInfo, eventInfoPollAllocated);
+      FreeIoEventResult(eventInfo, eventResultSize, eventInfoPollAllocated);
     }
     if (!IoBatch->DokanInstance->FileSystemStopped) {
       DokanDbgPrintW(
@@ -466,7 +481,7 @@ DWORD SendAndPullEventInformation(PDOKAN_IO_EVENT IoEvent,
     return lastError;
   }
   if (eventInfo) {
-    FreeIoEventResult(eventInfo, eventInfoPollAllocated);
+    FreeIoEventResult(eventInfo, eventResultSize, eventInfoPollAllocated);
   }
   return 0;
 }
@@ -897,7 +912,7 @@ ULONG DispatchGetEventInformationLength(ULONG bufferSize) {
              FIELD_OFFSET(EVENT_INFORMATION, Buffer[0]) + bufferSize);
 }
 
-VOID CreateDispatchCommon(PDOKAN_IO_EVENT IoEvent, ULONG SizeOfEventInfo, BOOL ClearBuffer) {
+VOID CreateDispatchCommon(PDOKAN_IO_EVENT IoEvent, ULONG SizeOfEventInfo, BOOL UseExtraMemoryPool, BOOL ClearNonPoolBuffer) {
   assert(IoEvent != NULL);
   assert(IoEvent->EventResult == NULL && IoEvent->EventResultSize == 0);
 
@@ -906,15 +921,38 @@ VOID CreateDispatchCommon(PDOKAN_IO_EVENT IoEvent, ULONG SizeOfEventInfo, BOOL C
     IoEvent->EventResultSize = DOKAN_EVENT_INFO_DEFAULT_SIZE;
     IoEvent->PoolAllocated = TRUE;
   } else {
-    IoEvent->EventResultSize =
-        DispatchGetEventInformationLength(SizeOfEventInfo);
-    IoEvent->EventResult = (PEVENT_INFORMATION)malloc(IoEvent->EventResultSize);
-    if (!IoEvent->EventResult) {
-      return;
+    if (UseExtraMemoryPool) {
+      if (SizeOfEventInfo <= (16 * 1024)) {
+        IoEvent->EventResult = Pop16KEventResult();
+        IoEvent->EventResultSize = DOKAN_EVENT_INFO_16K_SIZE;
+        IoEvent->PoolAllocated = TRUE;
+      } else if (SizeOfEventInfo <= (32 * 1024)) {
+        IoEvent->EventResult = Pop32KEventResult();
+        IoEvent->EventResultSize = DOKAN_EVENT_INFO_32K_SIZE;
+        IoEvent->PoolAllocated = TRUE;
+      } else if (SizeOfEventInfo <= (64 * 1024)) {
+        IoEvent->EventResult = Pop64KEventResult();
+        IoEvent->EventResultSize = DOKAN_EVENT_INFO_64K_SIZE;
+        IoEvent->PoolAllocated = TRUE;
+      } else if (SizeOfEventInfo <= (128 * 1024)) {
+        IoEvent->EventResult = Pop128KEventResult();
+        IoEvent->EventResultSize = DOKAN_EVENT_INFO_128K_SIZE;
+        IoEvent->PoolAllocated = TRUE;
+      }
+    }
+    if (IoEvent->EventResult == NULL) {
+      IoEvent->EventResultSize =
+          DispatchGetEventInformationLength(SizeOfEventInfo);
+      IoEvent->EventResult =
+          (PEVENT_INFORMATION)malloc(IoEvent->EventResultSize);
+      if (!IoEvent->EventResult) {
+        return;
+      }
+      ZeroMemory(IoEvent->EventResult,
+                 ClearNonPoolBuffer
+                     ? IoEvent->EventResultSize
+                     : FIELD_OFFSET(EVENT_INFORMATION, Buffer[0]));
     }
-    ZeroMemory(IoEvent->EventResult,
-               ClearBuffer ? IoEvent->EventResultSize
-                           : FIELD_OFFSET(EVENT_INFORMATION, Buffer[0]));
   }
   assert(IoEvent->EventResult &&
          IoEvent->EventResultSize >=