Add deviceUUID filter with DXVK_FILTER_DEVICE_UUID #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't ConvertUUID take a reference to uuid rather than a pointer ? |
misyltoad
reviewed
Feb 21, 2022
|
Could I get a review on this please? I have edited the OP to be more representative of the PR's current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #2036.
Please suggest improvements if you know of any.
This uses the same check as the DXVK_FILTER_DEVICE_NAME, so if any part of the UUID matches, it allows the device to be created.
Does not check for - in the UUID, as UUID contained in vulkaninfo does not contain these chars, they are simply added into the output stream before being displayed to the user. The first section of UUID also contains PCI bus info so should be enough to correctly ID a GPU. See comments on the review in this PR for more information.