Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d3d9] The Witcher EE - missing clouds / sky textures #1401

Closed
WinterSnowfall opened this issue Feb 5, 2020 · 2 comments · Fixed by #1404
Closed

[d3d9] The Witcher EE - missing clouds / sky textures #1401

WinterSnowfall opened this issue Feb 5, 2020 · 2 comments · Fixed by #1404

Comments

@WinterSnowfall
Copy link
Contributor

witcher_sky_dxvk

Related to #1399, regarding the missing sky textures when the in-game visibility range is set to "Far" (anything below will bring back the clouds).

The sun may be missing as well with dxvk considering the missing reflections/refraction in the water. All I have are cloudy weather saves (still better than negative thoughts), but if you think it's useful, I can dig a little and confirm this as well.

WineD3D will render everything correctly even on "Far":
witcher_sky_wined3d

Software information

The Witcher EE (GOG version, latest build).

System information

  • GPU: GeForce GTX 1070
  • Driver: 440.48.2
  • Wine version: 5.1 Staging
  • DXVK version: v1.5.3+87dd8f01

Apitrace file(s)

witcher.trace.tar.xz

Log files
@WinterSnowfall
Copy link
Contributor Author

... and the missing sun is confirmed by #1402 :)

@das-bub das-bub mentioned this issue Feb 5, 2020
Closed
doitsujin added a commit that referenced this issue Feb 5, 2020
@doitsujin
[d3d9] Don't arbitrarily set fog scale to 0
288a1cd 
The Witcher 1 sets FOGSTART == FOGEND together with LINEAR fog mode, in
which case we previously set fog_scale to 0 and therefore incorrectly
override the pixel color with the fog color.

Fixes #1401.
@doitsujin doitsujin mentioned this issue Feb 5, 2020
Merged
@doitsujin
Copy link
Owner

Should be fixed with the PR mentioned above:
Bildschirmfoto-1154

misyltoad pushed a commit that referenced this issue Feb 6, 2020
@doitsujin @misyltoad
[d3d9] Don't arbitrarily set fog scale to 0
0680958 
The Witcher 1 sets FOGSTART == FOGEND together with LINEAR fog mode, in
which case we previously set fog_scale to 0 and therefore incorrectly
override the pixel color with the fog color.

Fixes #1401.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[d3d9] Don't arbitrarily set fog scale to 0 doitsujin/dxvk
2 participants
@WinterSnowfall @doitsujin