Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated method File.exists? to File.exist? #159

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

tuttiq
Copy link

@tuttiq tuttiq commented May 5, 2023

Fix for this issue: #158

Fixes compatibility with ruby 3.2.

@tuttiq
Copy link
Author

tuttiq commented May 5, 2023

@knowtheory @jashkenas Any chance we get this merged?

@tmaier
Copy link
Contributor

tmaier commented Oct 16, 2023

Hi, I just ran into the same issue when trying to upgrade to Ruby 3.2. It would be great, if this could get merged. It should also not break compatibility to < 3.2-versions.

@tsotne-m
Copy link

tsotne-m commented Mar 4, 2024

@tuttiq any news about this topic?
I just encountered this issue. Maybe you used alternative for gem and could you tell me which one?

@tuttiq
Copy link
Author

tuttiq commented Mar 4, 2024

@tsotne-m (cc @tmaier) I ended up pointing the source for the gem (on my project's Gemfile) to my forked version: https://github.com/tuttiq/docsplit

Not great, but I figured this repository is no longer being maintained 🤷‍♀️ I don't plan on maintaining my fork either (since I'm not working on that project anymore), so I recommend you maintain your own forks if you need this gem long term.

@tsotne-m
Copy link

tsotne-m commented Mar 5, 2024

@tuttiq Thanks a lot for response

@krystof-k
Copy link

I'm just working on getting rid of Docsplit as well and it depends on your usecase, but in my case of using it to extract word processing documents, it looks like switching to something like libreconv (or just LibreOffice directly) to convert the document to PDF and then use pdf-reader to extract the text is the way to go.

@tmaier
Copy link
Contributor

tmaier commented Mar 10, 2024

I consider to use Apache Tika in the future. Especially, a tika microservice.

It has a simple REST API to extract text. See https://cwiki.apache.org/confluence/display/TIKA/TikaServer#TikaServer-GettheTextofaDocument

@abratashov
Copy link

Why this PR isn't merged? This is a common issue for all +Ruby 3.2 projects...
CC: @jashkenas @anujaware

@knowtheory knowtheory merged commit 67118b8 into documentcloud:master Aug 31, 2024
@abratashov
Copy link

❤️

@ckim2013
Copy link

ckim2013 commented Nov 5, 2024

have these changes been pushed to rubygems by any chance? as a workaround for our projects, we had to point the our gem to this repo's git directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants