Support doctrine/annotations 2 #10320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bump/annotations-2
branch
2 times, most recently
from
4a71cbb to
5571569
Compare
greg0ire
reviewed
Dec 19, 2022
| @@ -78,6 +78,9 @@ jobs: | |||
| run: "composer require doctrine/dbal ^${{ matrix.dbal-version }} --no-update" | |||
| if: "${{ matrix.dbal-version != 'default' }}" | |||
|
|
|||
| - name: "Uninstall PHPBench" | |||
| run: "composer remove --dev --no-update phpbench/phpbench" | |||
There was a problem hiding this comment.
I'm looking into adding support for v2 to phpbench
There was a problem hiding this comment.
I ran the tests locally, and apart from an unrelated failure, all is well.
There was a problem hiding this comment.
I think, we can live with this hack in our CI until PHPBench has merged and released your PR.
derrabus
force-pushed
the
bump/annotations-2
branch
2 times, most recently
from
f3d1c55 to
7e6c592
Compare
greg0ire
reviewed
Dec 19, 2022
derrabus
force-pushed
the
bump/annotations-2
branch
from
f783b84 to
3320e73
Compare
greg0ire
reviewed
Dec 19, 2022
| @@ -182,14 +183,21 @@ public function newDefaultAnnotationDriver($paths = [], $useSimpleAnnotationRead | |||
| } | |||
|
|
|||
| if ($useSimpleAnnotationReader) { | |||
There was a problem hiding this comment.
To be deprecated later on I suppose.
There was a problem hiding this comment.
The whole method is deprecated already and its replacement does not have that parameter anymore.
greg0ire
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until doctrine/annotations 2 has been released.
This PR allows the installation of Annotations 2 and fixes all failing tests.