Fix broken autoloading due to Reader calling registerFile #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 9, 2020
|
Looks like a sane approach. Just think that this seems would be a good opportunity to create a functional test for the reader, though. |
|
@alcaeus Please either write the functional test (if you plan to do it) or merge it and release it |
stof
approved these changes
Apr 18, 2020
|
Will create a test when I have more time on my hands. If anybody wants to contribute this, please do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @lcobucci, since the annotation reader invokes
AnnotationRegistry::registerFile, we automatically disable the autoload mechanism. This PR fixes this behaviour by exchanging calls toregisterFilebyclass_exists, invoking the standard autoloader we always assume to be present.