Support for use statement resolution in annotation property types #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
force-pushed
the
annotation-property-use-support
branch
from
a63b0ee to
13d5714
Compare
Majkl578
force-pushed
the
annotation-property-use-support
branch
from
13d5714 to
2c90267
Compare
Majkl578
commented
Apr 15, 2017
| // partially namespaced annotation instance | ||
| array( | ||
| 'partiallyNamedAnnotation', | ||
| 'Common\Annotations\Fixtures\AnnotationTargetAll', |
There was a problem hiding this comment.
This assumption is strange, it should be the FQCN, not the one used in declaration. It works fine with arrays - see arrayOf* tests below, but for non-array values, it doesn't seem to be correct...
Ocramius
suggested changes
Jul 22, 2017
| * | ||
| * @return void | ||
| */ | ||
| private function resolveUnqualifiedAttributeType(&$metadata, Attribute $attribute, ReflectionClass $class) |
There was a problem hiding this comment.
We should really avoid by-ref modification wherever possible
| * | ||
| * @return void | ||
| */ | ||
| private function resolveUnqualifiedType(&$type, ReflectionClass $class) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather simple approach to implement #86 / doctrine/common#562, originally reported by @enumag ages ago.☺️
I don't know the internals of doctrine/annotations well so any suggestions are welcome.