Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buble theme: fix strong font-weight increased to 600 (onto master branch) #952

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

xmedeko
Copy link
Contributor

@xmedeko xmedeko commented Nov 22, 2019

See #913 for the debate. TLDR:

I've separated strong and set it to 600. I've removed the a { font-weight: 400}, because it has overridden the headings h1, ... font-weight below.

(Links has blue color in the buble theme, so they do not need the slight font-weight increase. I also do not know how to keep font-weight and do not override headings, because headings are links to. I aware of CSS !important, but I think this solution is better for this situation.)

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@anikethsaha anikethsaha merged commit 8bf4b06 into docsifyjs:master Dec 3, 2019
@xmedeko xmedeko deleted the buble-patch-2 branch December 3, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants