Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docsify version to $window.docsify object #521

Closed
jhildenbiddle opened this issue Jun 7, 2018 · 1 comment
Closed

Add docsify version to $window.docsify object #521

jhildenbiddle opened this issue Jun 7, 2018 · 1 comment

Comments

@jhildenbiddle
Copy link
Member

Access to the current docsify version is useful when a plugin's behavior or theme styles are dependent on the docsify version.

$docsify.version // 4.6.10

It's a small addition that could make life much easier for plugin and theme authors down the road. 😄
@jhildenbiddle jhildenbiddle mentioned this issue Oct 9, 2018
Merged
QingWei-Li pushed a commit that referenced this issue Oct 23, 2018
@jhildenbiddle @QingWei-Li
feat: Add docsify version to $window.docsify object (#641)
94bc415 
Fix #521

Please makes sure these boxes are checked before submitting your PR, thank you!

* [ x ] Make sure you are merging your commits to `master` branch.
* [ x ] Add some descriptions and refer relative issues for you PR.
* [ x ] DO NOT include files inside `lib` directory.
@jhildenbiddle
Copy link
Member Author

@QingWei-Li -- See latest comment in #641. This feature worked in the PR I filed, but does not work in the released version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhildenbiddle