Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove note about buildkit not supporting git subdirectories #3125

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 8, 2021

depends on:

This has now been implemented in buildkit#2116, so this note can be removed (once integrated into Docker).

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

thaJeztah commented Jun 8, 2021

Hmm.. interesting failure on Jenkins


=== Failed
=== FAIL: e2e/container TestAttachExitCode (0.53s)
    attach_test.go:25: assertion failed: 
        Command:  docker run -d -i --rm registry:5000/alpine:3.6 sh -c read; exit 21
        ExitCode: 125
        Error:    exit status 125
        Stdout:   f4a92a9ab31f5d16421022479140a45c2eb432152c6556a5cc4c571ecdf70fed
        
        Stderr:   docker: Error response from daemon: cgroups: cgroup mountpoint does not exist: unknown.
        
        
        Failures:
        ExitCode was 125 expected 0
        Expected no error

Looks like Jenkins is running docker 19.03; could be that the workers switched to cgroups v2

@thaJeztah
Copy link
Member Author

And a flaky test?

=== Failed
=== FAIL: cli/command/container TestRemoveForce/without_force (0.00s)
Error: Error: No such container: nosuchcontainer
    --- FAIL: TestRemoveForce/without_force (0.00s)
        rm_test.go:37: assertion failed: 
            --- removed
            +++ →
            {[]string}[?->0]:
            	-: <non-existent>
            	+: "mycontainer"
            

@aidan-mundy
Copy link

Moby has revendored BuildKit, this likely needs to be merged now

This has now been implemented in buildkit#2116, so this note can
be removed (once integrated into Docker).

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the docs_update_buildkit_note branch from 4749b97 to 4f1ba37 Compare March 15, 2022 11:25
@thaJeztah thaJeztah changed the title [WIP] docs: remove note about buildkit not supporting git subdirectories docs: remove note about buildkit not supporting git subdirectories Mar 15, 2022
@thaJeztah thaJeztah marked this pull request as ready for review March 15, 2022 11:25
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 55cb22d into docker:master Mar 15, 2022
@thaJeztah thaJeztah deleted the docs_update_buildkit_note branch March 15, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants