Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action for too long diffs #15881

Closed
wants to merge 1 commit into from

Conversation

Felixoid
Copy link
Contributor

In #15846 the issue with too long body appeared. It prevents the service comment from being posted.

Here's the fix to truncate too-long diff.

@tianon
Copy link
Member

tianon commented Dec 11, 2023

Unfortunately this is somewhat intentional -- the generated diff is what we actually review, so if it's truncated, we have to generate it via other means and the failing CI is our signal to do so. We also use it as a rough "code smell" (because a "diff too long" in a Dockerization is usually a sign that something else has gone wrong; new image PRs with lots of versions are a bit of an exceptional case).

@tianon tianon closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants