-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved caching in multiple areas #5822
Merged
valadas
merged 4 commits into
dnnsoftware:develop
from
skamphuis:feature/5819-Improvements-Caching
Oct 13, 2023
Merged
Improved caching in multiple areas #5822
valadas
merged 4 commits into
dnnsoftware:develop
from
skamphuis:feature/5819-Improvements-Caching
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, this would only happen when requesting a tab for another portal than the one it's in, but using an external cache we have seen this a lot and this fix prevent a lot of unnecessary ClearCache calls.
mitchelsellers
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
valadas
requested changes
Sep 22, 2023
DNN Platform/Modules/HTML/Components/WorkflowStateController.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Components/WorkflowStateController.cs
Outdated
Show resolved
Hide resolved
bdukes
reviewed
Sep 25, 2023
bdukes
approved these changes
Oct 13, 2023
@valadas can we get another review from you to clear the requested changes review |
valadas
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
valadas
changed the title
Feature/5819 improvements caching
Improved caching in multiple areas
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relats to #5819 and covers the caching-related changes: