Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved caching in multiple areas #5822

Merged

Conversation

skamphuis
Copy link
Contributor

This PR relats to #5819 and covers the caching-related changes:

  • Fix serialization errors when using external cache
  • HTML/Text: implement caching for GetWorkflows
  • Only do a clearcache when unknown tab belongs to the portal whose cache is being flushed.
  • TabController: only clear cache when tab is for the current portal

In practice, this would only happen when requesting a tab for another portal than the one it's in, but using an external cache we have seen this a lot and this fix prevent a lot of unnecessary ClearCache calls.
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@bdukes bdukes added this to the 9.13.1 milestone Oct 13, 2023
@bdukes bdukes requested a review from valadas October 13, 2023 14:46
@mitchelsellers
Copy link
Contributor

@valadas can we get another review from you to clear the requested changes review

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit df634b6 into dnnsoftware:develop Oct 13, 2023
3 checks passed
@valadas valadas changed the title Feature/5819 improvements caching Improved caching in multiple areas Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants