Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot "unselect" Google Analytics (Legacy UA) connector #5900

Closed
2 tasks done
skarpik opened this issue Jan 1, 2024 · 2 comments · Fixed by #5972
Closed
2 tasks done

[Bug]: Cannot "unselect" Google Analytics (Legacy UA) connector #5900

skarpik opened this issue Jan 1, 2024 · 2 comments · Fixed by #5972
Assignees

Comments

@skarpik
Copy link

skarpik commented Jan 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I have a website that had the Google Analytics (Legacy UA) connector enabled. I wanted to use the Google Tag Manager connector. I set that connection up with no problem. But then I cannot delete the Google Analytics (Legacy UA) connector - a JavaScript error results.

Steps to reproduce?

  1. Started with an older website that has been upgraded to DNN v9.13.1.
  2. Successfully added the Google Tag Manager connector.
  3. Failed at deleting the Google Analytics (Legacy UA) connector.
  4. Found a JavaScript error (see below).
  5. Now it looks like both the Google Analytics (Legacy UA) and Google Tag Manager connectors are enabled.
Screenshot 2024-01-01 004150

Current Behavior

JavaScript error after clicking "Delete Connection".

jquery.js?cdv=216:2 Uncaught Error: Syntax error, unrecognized expression: #connector-Google Analytics (Legacy UA)
at I.error (jquery.js?cdv=216:2:11769)
at Y (jquery.js?cdv=216:2:17234)
at re (jquery.js?cdv=216:2:20008)
at Function.I [as find] (jquery.js?cdv=216:2:7520)
at ce.fn.init.find (jquery.js?cdv=216:2:21991)
at new ce.fn.init (jquery.js?cdv=216:2:22483)
at ce (jquery.js?cdv=216:2:1077)
at saveConnection (Connectors.js?cdv=216:305:34)
at Object.save (Connectors.js?cdv=216:132:21)
at Object.action (connector.js?cdv=216:107:30)

Expected Behavior

The delete button should delete the legacy connector when clicked on.

Relevant log output

No response

Anything else?

No response

Affected Versions

9.13.0 (latest release)

What browsers are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Code of Conduct

  • I agree to follow this project's Code of Conduct
@david-poindexter
Copy link
Contributor

@skarpik thanks for logging this issue.

@bdukes I took a quick look and see this is related to that code section that we had some trouble with a while back (not able to save when tracking for admins). I didn't have time to dig too deep, but thought I would mention you just in case you have time before me.

@cklenk
Copy link

cklenk commented Feb 15, 2024

Same issue as #5867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants