-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving multiple versions of xgb models #734
Conversation
@glr72 Thanks but some people might want to only save 1 version though. It would be better if, instead, you can add a parameter |
hi terrytangyuan, I implemented your proposal. You have parameter max_to_keep (default = 0), which works as you suggested. |
@glr72 Thank you. Could you squash your commits into one and add yourself to CONTRIBUTORS? |
Hi terrytangyuan, |
There are many ways to do this but here's one that's on top of my mind and you can just copy and paste.
For your reference, you should look into how to use |
Ok I did it. There's a problem with the CONTRIBUTOR file but it looks to be not relevant. |
Good job! Looks like it has conflicts with CONTRIBUTORS. Could you resolve it or do a
and I'll add you there myself. Thanks! |
commands executed (actually --forcec and not --hard) Thanks again |
@glr72 I don't see any changes though. Mind trying it again? |
closing this PR for now and refer to #892 for new guidelines with respect to adding these related features |
Hi,
the small change below allows to save more than 1 version of the model (in the main xgb.train.R it is always overwritten).