Create renderers lazily #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to utilize their custom storage handler while not having to include gson and java.prefs as a dependency.
|
This PR should compile now with FormsFX 11.6.0 |
|
Did my PR mess up the release pipeline? |
|
No, I think it is an issue with Maven Central. I just started the release workflow again. Let's see if it works today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the matching PR for dlsc-software-consulting-gmbh/FormsFX#65. The changes are straightforward and also backwards compatible. However they only compile when using the proper FormsFX commit/version.
One addition I included is also something that has been bugging me for a while and is about module dependencies. I use my own storage handler implementation and therefore don't use any of the java.prefs or gson modules, but as they are not declared static in the module-info, compilation will fail when they are not in the module path. This PR should fix that as well.