Setup coursier w/o embedding in the extension #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
force-pushed
the
dfrancoeur/download-coursier
branch
from
bc86cab to
c4bbfe2
Compare
Baccata
reviewed
Feb 23, 2022
daddykotex
force-pushed
the
dfrancoeur/download-coursier
branch
from
c4bbfe2 to
bc86cab
Compare
Baccata
reviewed
Feb 23, 2022
In order, we do: 1. look for coursier on the path 2. if found, we use it (cs or coursier) 3. it !found, we download it Downloading only happens if the file does not already exist on the file system
daddykotex
force-pushed
the
dfrancoeur/download-coursier
branch
from
bc86cab to
deddb59
Compare
|
From now on, please refrain from force-pushing once a PR has been open, unless the situation warrants it. |
Baccata
reviewed
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order, we do:
Downloading only happens if the file does not already exist on
the file system
I have not included @kubukoz comment regarding the location of the download (still in the extension directory in this PR)
I will open a separate issue for this.