perf(Role): linear speed position getter (#9493)

Co-authored-by: Jiralite <[email protected]>
discordjs · May 5, 2023 · 8e9a2b4 · 8e9a2b4
1 parent d4f12e0
commit 8e9a2b4
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/discord.js/src/structures/Role.js b/packages/discord.js/src/structures/Role.js
@@ -188,8 +188,14 @@ class Role extends Base {
    * @readonly
    */
   get position() {
-    const sorted = this.guild._sortedRoles();
-    return [...sorted.values()].indexOf(sorted.get(this.id));
+    return this.guild.roles.cache.reduce(
+      (acc, role) =>
+        acc +
+        (this.rawPosition === role.rawPosition
+          ? BigInt(this.id) > BigInt(role.id)
+          : this.rawPosition > role.rawPosition),
+      0,
+    );
   }
 
   /**