Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add premium buttons #2752

Merged
merged 22 commits into from
Nov 3, 2024

Conversation

freya022
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Implements changes of https://discord.com/developers/docs/change-log#premium-apps-new-premium-button-style-deep-linking-url-schemes.

Deprecated the premium reply callback, which are replaced with premium buttons.

@freya022 freya022 marked this pull request as ready for review October 14, 2024 21:58
@freya022 freya022 force-pushed the feature/premium-buttons branch from ebc464f to 54ece60 Compare October 14, 2024 22:01
@freya022 freya022 force-pushed the feature/premium-buttons branch from 54ece60 to 9e4071b Compare October 14, 2024 22:04
- Checks validity in common method
- Prevents changing emoji/url/id on incompatible types
- Support premium styles in general-purpose factories
- Moved test constants to constant fields
- Added tests for "with" methods

Co-authored-by: Florian Spieß <[email protected]>
@MinnDevelopment MinnDevelopment merged commit 8ccfc56 into discord-jda:master Nov 3, 2024
1 check passed
@freya022 freya022 deleted the feature/premium-buttons branch November 3, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants