Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScheduledEvent::getJumpUrl #2736

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Add ScheduledEvent::getJumpUrl #2736

merged 2 commits into from
Oct 5, 2024

Conversation

raul1ro
Copy link
Contributor

@raul1ro raul1ro commented Sep 19, 2024 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Description

Added the getJumpUrl method to the ScheduledEvent interface, and implemented it in ScheduledEventImpl class (the only implementation of ScheduledEvent).

DV8FromTheWorld
DV8FromTheWorld approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DV8FromTheWorld DV8FromTheWorld merged commit 57f7c0a into discord-jda:master Oct 5, 2024
1 check passed
@MinnDevelopment MinnDevelopment mentioned this pull request Oct 5, 2024
Merged
6 tasks
@renovate renovate bot mentioned this pull request Dec 8, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raul1ro @DV8FromTheWorld @MinnDevelopment