Fix deserialization of interaction components #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/net/dv8tion/jda/internal/interactions/modal/ModalImpl.java
Outdated
Show resolved
Hide resolved
|
Thanks! |
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-client
Aug 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | debian | final | digest | `5f7d566` -> `2ccc7e3` | | | | | | maven | stage | digest | `6bfb613` -> `7bec384` | | | | | | rust | stage | minor | `1.79.0-bookworm` -> `1.80.1-bookworm` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [net.dv8tion:JDA](https://togithub.com/discord-jda/JDA) | compile | patch | `5.0.1` -> `5.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.github.sealedtx:java-youtube-downloader](https://togithub.com/sealedtx/java-youtube-downloader) | compile | patch | `3.2.3` -> `3.2.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>discord-jda/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.2`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.2): | Single time event listener ### Overview This release includes some bug fixes as well as a new event listener feature to add a one-time-use event listener. ##### Once Event Listener ([#​2683](https://togithub.com/discord-jda/JDA/issues/2683)) A common problem that developers run into, is "waiting" for a specific event in the context of some command. For instance, waiting for a user to add a reaction or reply with a message in response to some prompt. This can now be achieved using the new [listenOnce](https://docs.jda.wiki/net/dv8tion/jda/api/JDA.html#listenOnce\(java.lang.Class\)) event listener: ```java // listen for a message event jda.listenOnce(MessageReceivedEvent.class) // filter for specific event .filter(event -> event.getChannel().equals(channel)) .filter(event -> event.getAuthor().equals(user)) // handle timeout .timeout(timeout, () -> hook.editOriginal("Timeout!").queue()) // subscribe to first event that matches filters .subscribe(event -> { hook.editOriginal("You sent: " + event.getMessage().getContentRaw()).queue(); }); ``` #### New Features - Add `TeamMember.RoleType` by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2703](https://togithub.com/discord-jda/JDA/pull/2703) - Add abstract `createCopy` method in `SelectMenu` by [@​Kaktushose](https://togithub.com/Kaktushose) in [https://github.com/discord-jda/JDA/pull/2684](https://togithub.com/discord-jda/JDA/pull/2684) - Add `JDA#listenOnce` by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2683](https://togithub.com/discord-jda/JDA/pull/2683) - Add support for profile automod by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2580](https://togithub.com/discord-jda/JDA/pull/2580) #### Changes - Expand list of retried http error codes by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2710](https://togithub.com/discord-jda/JDA/pull/2710) - Update to Jackson 2.17.2 by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2695](https://togithub.com/discord-jda/JDA/pull/2695) #### Bug Fixes - Fix deserialization of interaction components by [@​WitchBoo](https://togithub.com/WitchBoo) in [https://github.com/discord-jda/JDA/pull/2711](https://togithub.com/discord-jda/JDA/pull/2711) **Full Changelog**: discord-jda/JDA@v5.0.1...v5.0.2 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.2") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.2</version> </dependency> ``` </details> <details> <summary>sealedtx/java-youtube-downloader (com.github.sealedtx:java-youtube-downloader)</summary> ### [`v3.2.4`](https://togithub.com/sealedtx/java-youtube-downloader/releases/tag/3.2.4) [Compare Source](https://togithub.com/sealedtx/java-youtube-downloader/compare/3.2.3...3.2.4) added missing itags </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on saturday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Description
It fixes the deserialization of some interaction components. Actually, I identified two classes that are deserializing in a wrong way.
ModalImpl: isn't using custom_id if available. When converting to data, it saves the id as custom_id
TextInputImpl: serializes minimum length as min_length but actually uses min_Length