Fix CommandInteractionPayload#getCommandString in autocomplete interactions
#2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/net/dv8tion/jda/api/interactions/commands/CommandInteractionPayload.java
Outdated
Show resolved
Hide resolved
BachErik
referenced
this pull request
in BachErik/Hypixel-Stats-generator
Apr 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | `5.0.0-beta.22` -> `5.0.0-beta.23` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.23`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.23): | Message Polls ### Overview This release includes an updated README, please let us know if you spot any issues with it! ##### Polls ([#​2649](https://togithub.com/DV8FromTheWorld/JDA/issues/2649)) Discord has recently released a new feature on their platform to start and vote in polls. These polls can now be sent in messages: ```java channel.sendMessage("Hello guys! Check my poll:") .setPoll( MessagePollData.builder("Which programming language is better?") .addAnswer("Java", Emoji.fromFormatted("<:java:1006323566314274856>")) .addAnswer("Kotlin", Emoji.fromFormatted("<:kotlin:295940257797636096>")) .build()) .queue() ``` The poll automatically expires after a set duration, configurable in the `MessagePollBuilder` using [setDuration](https://docs.jda.wiki/net/dv8tion/jda/api/utils/messages/MessagePollBuilder.html#setDuration\(java.time.Duration\)). A poll can also be ended manually using [endPoll](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Message.html#endPoll\(\)) or [endPollById](https://docs.jda.wiki/net/dv8tion/jda/api/entities/channel/middleman/MessageChannel.html#endPollById\(java.lang.String\)). You can check the poll votes on a message using the new `Message#getPoll`: ```java MessagePoll poll = message.getPoll(); for (MessagePoll.Answer answer : poll.getAnswers()) { System.out.printf("Poll Answer %s has %d votes\n", answer.getText(), answer.getVotes()); } ``` > \[!NOTE] > The votes for polls are eventually consistent and need to be recounted after the poll ends. You can check whether the votes are validated using [MessagePoll#isFinalizedVotes](https://docs.jda.wiki/net/dv8tion/jda/api/entities/messages/MessagePoll.html#isFinalizedVotes\(\)). #### New Features - Add USER_MUST_BE_VERIFIED ErrorResponse by [@​GitMilchi](https://togithub.com/GitMilchi) in [https://github.com/discord-jda/JDA/pull/2651](https://togithub.com/discord-jda/JDA/pull/2651) - Update permission enum by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2654](https://togithub.com/discord-jda/JDA/pull/2654) - Poll support by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2649](https://togithub.com/discord-jda/JDA/pull/2649) #### Changes - Update dependencies and use version catalog by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2652](https://togithub.com/discord-jda/JDA/pull/2652) #### Bugs Fixes - Fix `CommandInteractionPayload#getCommandString` in autocomplete interactions by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2659](https://togithub.com/discord-jda/JDA/pull/2659) **Full Changelog**: discord-jda/JDA@v5.0.0-beta.22...v5.0.0-beta.23 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.23") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.23</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/BachErik/Hypixel-Stats-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-client
Apr 28, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | debian | final | digest | `3d5df92` -> `155280b` | | | | | | rust | stage | digest | `6052afe` -> `8f891e6` | | | | | | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | compile | patch | `5.0.0-beta.22` -> `5.0.0-beta.23` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.23`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.23): | Message Polls [Compare Source](https://togithub.com/DV8FromTheWorld/JDA/compare/v5.0.0-beta.22...v5.0.0-beta.23) ### Overview This release includes an updated README, please let us know if you spot any issues with it! ##### Polls ([#​2649](https://togithub.com/DV8FromTheWorld/JDA/issues/2649)) Discord has recently released a new feature on their platform to start and vote in polls. These polls can now be sent in messages: ```java channel.sendMessage("Hello guys! Check my poll:") .setPoll( MessagePollData.builder("Which programming language is better?") .addAnswer("Java", Emoji.fromFormatted("<:java:1006323566314274856>")) .addAnswer("Kotlin", Emoji.fromFormatted("<:kotlin:295940257797636096>")) .build()) .queue() ``` The poll automatically expires after a set duration, configurable in the `MessagePollBuilder` using [setDuration](https://docs.jda.wiki/net/dv8tion/jda/api/utils/messages/MessagePollBuilder.html#setDuration\(java.time.Duration\)). A poll can also be ended manually using [endPoll](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Message.html#endPoll\(\)) or [endPollById](https://docs.jda.wiki/net/dv8tion/jda/api/entities/channel/middleman/MessageChannel.html#endPollById\(java.lang.String\)). You can check the poll votes on a message using the new `Message#getPoll`: ```java MessagePoll poll = message.getPoll(); for (MessagePoll.Answer answer : poll.getAnswers()) { System.out.printf("Poll Answer %s has %d votes\n", answer.getText(), answer.getVotes()); } ``` > \[!NOTE] > The votes for polls are eventually consistent and need to be recounted after the poll ends. You can check whether the votes are validated using [MessagePoll#isFinalizedVotes](https://docs.jda.wiki/net/dv8tion/jda/api/entities/messages/MessagePoll.html#isFinalizedVotes\(\)). #### New Features - Add USER_MUST_BE_VERIFIED ErrorResponse by [@​GitMilchi](https://togithub.com/GitMilchi) in [https://github.com/discord-jda/JDA/pull/2651](https://togithub.com/discord-jda/JDA/pull/2651) - Update permission enum by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2654](https://togithub.com/discord-jda/JDA/pull/2654) - Poll support by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2649](https://togithub.com/discord-jda/JDA/pull/2649) #### Changes - Update dependencies and use version catalog by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2652](https://togithub.com/discord-jda/JDA/pull/2652) #### Bugs Fixes - Fix `CommandInteractionPayload#getCommandString` in autocomplete interactions by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2659](https://togithub.com/discord-jda/JDA/pull/2659) **Full Changelog**: discord-jda/JDA@v5.0.0-beta.22...v5.0.0-beta.23 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.23") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.23</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on sunday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
When printing a command string, in an autocomplete interaction, an
IllegalStateExceptioncould occur when an entity is in that command, as Discord does not send resolved entities there