Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy Warnings #1300

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Fix Clippy Warnings #1300

merged 2 commits into from
Dec 16, 2023

Conversation

JulianKnodt
Copy link
Contributor

No description provided.

@JulianKnodt JulianKnodt force-pushed the clippy branch 2 times, most recently from 895e44d to 127ddf7 Compare September 25, 2023 07:46
Ralith
Ralith approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM overall. Could you rebase?

src/base/storage.rs Outdated Show resolved Hide resolved
src/geometry/rotation.rs Outdated Show resolved Hide resolved
@JulianKnodt JulianKnodt force-pushed the clippy branch 3 times, most recently from e6bf220 to df92c61 Compare December 16, 2023 17:56
@Ralith Ralith merged commit 1e0cb7b into dimforge:dev Dec 16, 2023
11 of 12 checks passed
@JulianKnodt JulianKnodt deleted the clippy branch December 16, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andlon Andlon Andlon left review comments

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulianKnodt @Ralith @Andlon