Rewrite PRSelf when loading a dependency package #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hurryabit
force-pushed
the
rewrite-prself
branch
from
b1cc3d9 to
a7eee19
Compare
cocreature
approved these changes
Nov 9, 2019
hurryabit
force-pushed
the
rewrite-prself
branch
from
a7eee19 to
7b63785
Compare
hurryabit
force-pushed
the
rewrite-prself
branch
3 times, most recently
from
3a8ce45 to
0b46b64
Compare
ghost
approved these changes
Nov 10, 2019
| @@ -554,7 +554,8 @@ createProjectPackageDb opts thisSdkVer deps0 dataDeps = do | |||
| forM allDalfs $ \(name, dalf) -> do | |||
| (pkgId, package) <- | |||
| either (fail . DA.Pretty.renderPretty) pure $ | |||
| Archive.decodeArchive dalf | |||
| -- FIXME(MH): This keeps the old behaviour but seems wrong to me. | |||
There was a problem hiding this comment.
No need to rewrite self references here, the dalf won't be linked or typechecked and for code generation it's easier if you just have the PRSelf references and translate those to the unit it.
When buidling simple project that has our favourite large project as a dependency, this decreased - total allocations from 63GB to 57GB - run time from 34.0s to 31.5s
hurryabit
force-pushed
the
rewrite-prself
branch
from
0b46b64 to
aada4ba
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
When buidling simple project that has our favourite large project as a dependency, this decreased - total allocations from 63GB to 57GB - run time from 34.0s to 31.5s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we first load the package as is and rewrite the
PRSelfreferences in a second step. This PR moves the rewriting directly
in the loading step.
When buidling simple project that has our favourite large project as a
dependency, this decreased
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.
This change is