Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider only artifacts with "osgi.bundle" classifier #156

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Sep 9, 2021

Fixes #155


After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md that includes:

  • a summary of the change
  • a link to the newly created PR

This makes it easier for the maintainers to quickly release your changes.

@@ -42,7 +42,23 @@ private void assert463(Map<String, String> bundleToVersion) {
Assertions.assertThat(bundleToVersion)
.containsEntry("org.eclipse.debug.core", "3.10.100")
.containsEntry("org.eclipse.equinox.p2.metadata", "2.3.100")
.hasSize(895);
.containsEntry("org.eclipse.help", "3.7.0")
.hasSize(743);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

743 is also the size returned bnd when listing the content of the
https://download.eclipse.org/eclipse/updates/4.6/

Output: https://github.com/jmini/ecentral/blob/master/data/4.6/bnd-output.txt


Approach described on stackoverflow:
How to programmatically query a p2 repository for information and artifacts?

.containsEntry("org.eclipse.debug.core", "3.14.100")
.containsEntry("org.eclipse.equinox.p2.metadata", "2.4.600")
.containsEntry("org.eclipse.help", "3.8.600")
.hasSize(785);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

785 is also the size returned bnd when listing the content of the
https://download.eclipse.org/eclipse/updates/4.14/

Output: https://github.com/jmini/ecentral/blob/master/data/4.14/bnd-output.txt


Approach described on stackoverflow:
How to programmatically query a p2 repository for information and artifacts?

@nedtwigg nedtwigg merged commit f835c93 into diffplug:main Sep 9, 2021
@nedtwigg
Copy link
Member

nedtwigg commented Sep 9, 2021

Thanks for the PR, published in 3.32.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eclipseMavenCentral selects wrong "org.eclipse.help" version
2 participants