Add: Typing Sound Audio Bus in Character Settings #2425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CakeVR
requested changes
Oct 10, 2024
addons/dialogic/Modules/Text/character_settings/character_moods_settings.gd
Outdated
Show resolved
Hide resolved
addons/dialogic/Modules/Text/character_settings/character_moods_settings.tscn
Outdated
Show resolved
Hide resolved
Co-authored-by: Cake <[email protected]>
Thanks @CakeVR for your review: I have applied the changes you suggested. |
|
The problem I have with this solution is that you use I don't think this is a good solution. |
|
I don't think this should be a setting in the character editor, rather a global setting or a style setting. I cannot see a use-case where you'd need to change this per type sound mood. |
|
Hello, is there any interest in continuing on this PR? |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field "Audio Bus" into the character settings typing sounds section:
The Audio Bus is an OptionButton field which values are populated from AudioServer buses.
I decided to make the change after opening the issue:
#2420