-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table layout #146
Draft
dhilt
wants to merge
12
commits into
master
Choose a base branch
from
table-layout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Table layout #146
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
228296c
table layout dev
dhilt e38ad82
Remove intermediate <div ui-scroll> wrapping tag for ui-scroll component
markdBC aa0b8b4
Merge pull request #145 from markdBC/table-layout
dhilt 852f072
Merge branch 'master' into table-layout
dhilt 928a285
ng-template fix
dhilt 12222ad
pass parent element from directive + ngOnInit fake call
dhilt 86be8e4
Explicitly invoke change detection after dynamically creating compone…
markdBC cd6232d
Merge pull request #147 from markdBC/table-layout
dhilt 467a7e2
delayed change detection: the workflow must be initialized after firs…
dhilt 15bd614
Merge branch 'master' into table-layout
dhilt e086b97
Merge branch 'master' into table-layout
dhilt d455c33
Merge branch 'master' of github.com:dhilt/ngx-ui-scroll into table-la…
dhilt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markdBC I admire your deep insight of the Angular internal things and very grateful for your explanation regarding ngOnInit. As you can see I had to wrap changes detection into another
setTimeout
, the problem is that theonInit
hook is being triggered (with manual approach) before the initial content of the component is rendered. Do you know, what can be done here? I tried to replaceOnInit
withAfterViewInit
(the latest init hook), but it also runs too early.The initialization, I need to run on the components first render, includes DOM parsing, in particular, the Scroller tries to find elements needed for virtualization. And immediate initialization (before DOM gets necessary elements during first render) just fails.
Also, calling
componentRef.changeDetectorRef.detectChanges()
seems equal to callingcomponentRef.instance.ngOnInit()
, but I agree this is better than callingthis.ngOnInit()
on the component's constructor.That's what we have now... And it would be great to dig a little dipper and find a way to catch the time of the first render properly. The last thing I want to add is that the demo starts working, not perfect, but something can be seen running localhost:4200/#/test