refactor: use private methods (#1425)

dherault · May 18, 2022 · f04e57c · f04e57c
1 parent a332dbf
commit f04e57c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/events/http/Http.js b/src/events/http/Http.js
@@ -17,15 +17,15 @@ export default class Http {
     return this.#httpServer.stop(timeout)
   }
 
-  _create(functionKey, rawHttpEventDefinition, handler) {
+  #createEvent(functionKey, rawHttpEventDefinition, handler) {
     const httpEvent = new HttpEventDefinition(rawHttpEventDefinition)
 
     this.#httpServer.createRoutes(functionKey, httpEvent, handler)
   }
 
   create(events) {
     events.forEach(({ functionKey, handler, http }) => {
-      this._create(functionKey, http, handler)
+      this.#createEvent(functionKey, http, handler)
     })
 
     this.#httpServer.writeRoutesTerminal()

diff --git a/src/events/websocket/WebSocket.js b/src/events/websocket/WebSocket.js
@@ -48,7 +48,7 @@ export default class WebSocket {
     ])
   }
 
-  _create(functionKey, rawWebSocketEventDefinition) {
+  #createEvent(functionKey, rawWebSocketEventDefinition) {
     const webSocketEvent = new WebSocketEventDefinition(
       rawWebSocketEventDefinition,
     )
@@ -58,7 +58,7 @@ export default class WebSocket {
 
   create(events) {
     events.forEach(({ functionKey, websocket }) => {
-      this._create(functionKey, websocket)
+      this.#createEvent(functionKey, websocket)
     })
   }
 }
diff --git a/src/lambda/Lambda.js b/src/lambda/Lambda.js
@@ -25,14 +25,14 @@ export default class Lambda {
     )
   }
 
-  _create(functionKey, functionDefinition) {
+  #createEvent(functionKey, functionDefinition) {
     this.#lambdas.set(functionKey, functionDefinition)
     this.#lambdaFunctionNamesKeys.set(functionDefinition.name, functionKey)
   }
 
   create(lambdas) {
     lambdas.forEach(({ functionKey, functionDefinition }) => {
-      this._create(functionKey, functionDefinition)
+      this.#createEvent(functionKey, functionDefinition)
     })
   }
 

diff --git a/src/lambda/handler-runner/go-runner/GoRunner.js b/src/lambda/handler-runner/go-runner/GoRunner.js
@@ -161,7 +161,7 @@ export default class GoRunner {
       // refresh go.mod
       sync('go', ['mod', 'tidy'])
       chdir(this.#codeDir)
-    } catch (e) {
+    } catch {
       // @ignore
     }