refactor: unsupported docker runtimes

dherault · Sep 3, 2022 · c4a53d9 · c4a53d9
1 parent 3b9e45f
commit c4a53d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/config/supportedRuntimes.js b/src/config/supportedRuntimes.js
@@ -45,3 +45,5 @@ export const supportedRuntimes = new Set([
   ...supportedPython,
   ...supportedRuby,
 ])
+
+export const unsupportedDockerRuntimes = new Set(['nodejs14.x', 'python3.9'])
diff --git a/src/lambda/handler-runner/HandlerRunner.js b/src/lambda/handler-runner/HandlerRunner.js
@@ -5,6 +5,7 @@ import {
   supportedNodejs,
   supportedPython,
   supportedRuby,
+  unsupportedDockerRuntimes,
 } from '../../config/index.js'
 
 export default class HandlerRunner {
@@ -29,19 +30,13 @@ export default class HandlerRunner {
     log.debug(`Loading handler... (${handler})`)
 
     if (useDocker) {
-      // https://github.com/lambci/docker-lambda/issues/329
-      if (runtime === 'nodejs14.x') {
+      if (unsupportedDockerRuntimes.has(runtime)) {
         log.warning(
-          '"nodejs14.x" runtime is not supported with docker. See https://github.com/lambci/docker-lambda/issues/329',
+          `"${runtime}" runtime is not supported with docker. See https://github.com/lambci/docker-lambda`,
         )
         throw new Error('Unsupported runtime')
       }
 
-      if (runtime === 'python3.9') {
-        log.warning('"python3.9" runtime is not supported with docker.')
-        throw new Error('Unsupported runtime')
-      }
-
       const dockerOptions = {
         host: this.#options.dockerHost,
         hostServicePath: this.#options.dockerHostServicePath,