refactor: conditionally install node-fetch globally vs. node.js v18+

.eslintrc.cjs

@@ -2,6 +2,7 @@
 
 module.exports = {
   env: {
+    es2021: true,
     jest: true,
   },
 
@@ -12,6 +13,11 @@ module.exports = {
   ],
 
   globals: {
+    // TODO remove `node-fetch` module with node.js v18+ support
+    // TODO file bug with eslint? those should be global now
+    fetch: true,
+    Headers: true,
+    //
     RUN_TEST_AGAINST_AWS: true,
     TEST_BASE_URL: true,
   },

src/index.js

@@ -1,4 +1,12 @@
 // TODO remove with node.js v16.9+ support
 import 'object.hasown/auto'
 
+// install global fetch
+// TODO remove `node-fetch` module and use global built-in with node.js v18+ support
+if (globalThis.fetch === undefined) {
+  const { default: fetch, Headers } = await import('node-fetch')
+  globalThis.fetch = fetch
+  globalThis.Headers = Headers
+}
+
 export { default } from './ServerlessOffline.js'

src/lambda/handler-runner/docker-runner/DockerContainer.js

@@ -8,7 +8,6 @@ import { Lambda } from 'aws-sdk'
 import { execa } from 'execa'
 import { ensureDir, pathExists } from 'fs-extra'
 import jszip from 'jszip'
-import fetch from 'node-fetch'
 import pRetry from 'p-retry'
 import DockerImage from './DockerImage.js'
 

src/lambda/handler-runner/java-runner/JavaRunner.js

@@ -1,6 +1,5 @@
 import { EOL } from 'node:os'
 import process from 'node:process'
-import fetch from 'node-fetch'
 import { log } from '@serverless/utils/log.js'
 import { invokeJavaLocal } from 'java-invoke-local'
 

src/lambda/routes/invocations/invocationsRoute.js

@@ -1,5 +1,4 @@
 import { Buffer } from 'node:buffer'
-import { Headers } from 'node-fetch'
 import InvocationsController from './InvocationsController.js'
 
 const { parse } = JSON

tests/endToEnd/environmentVariables/environmentVariables.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import {
   joinUrl,
   setup,

tests/endToEnd/optionParameters/optionParameters.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import {
   joinUrl,
   setup,

tests/endToEnd/starRoutes/starRoutes.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import {
   joinUrl,
   setup,

tests/endToEnd/starRoutesWithProperties/starRoutes.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import {
   joinUrl,
   setup,

tests/endToEnd/trailingSlash/trailingSlash.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import {
   joinUrl,
   setup,

tests/integration/artifact/local/localArtifact.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import {
   compressArtifact,
   joinUrl,

tests/integration/authorizer/authorizer.test.js

@@ -5,7 +5,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/integration/custom-authentication/authenticationCustomVariable.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/integration/docker/access-host/accessHost.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
 import { Server } from '@hapi/hapi'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 
 // "Could not find 'Docker', skipping 'Docker' tests."

tests/integration/docker/artifact/artifact.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import {
   compressArtifact,
   joinUrl,

tests/integration/docker/go/go1.x/dockerGo1.x.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import {
   joinUrl,
   buildInContainer,

tests/integration/docker/layers/dockerLayers.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 
 // "Could not find 'Docker', skipping 'Docker' tests."

tests/integration/docker/multiple/dockerMultiple.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import semver from 'semver'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 

tests/integration/docker/nodejs/nodejs10.x/dockerNodejs10.x.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import semver from 'semver'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 

tests/integration/docker/nodejs/nodejs12.x/dockerNodejs12.x.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import semver from 'semver'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 

tests/integration/docker/nodejs/nodejs8.10/dockerNodejs8.10.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import semver from 'semver'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 

tests/integration/docker/provided/dockerProvided.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 
 // "Could not find 'Docker', skipping 'Docker' tests."

tests/integration/docker/python/python3.6/dockerPython3.6.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 
 // "Could not find 'Docker', skipping 'Docker' tests."

tests/integration/docker/python/python3.7/dockerPython3.7.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 
 // "Could not find 'Docker', skipping 'Docker' tests."

tests/integration/docker/python/python3.8/dockerPython3.8.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 
 // "Could not find 'Docker', skipping 'Docker' tests."

tests/integration/docker/ruby/ruby2.7/dockerRuby2.7.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import semver from 'semver'
 import { joinUrl, setup, teardown } from '../../../_testHelpers/index.js'
 

tests/integration/go/go1.x/go1.x.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { platform } from 'node:os'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 
 const _describe =

tests/integration/groovy/groovy.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 // Could not find 'Java', skipping 'Java' tests.

tests/integration/handler/handlerPayload.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const { stringify } = JSON

tests/integration/httpApi-cors-default/httpApi-cors-default.test.js

@@ -5,7 +5,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/integration/httpApi-cors/httpApi-cors.test.js

@@ -5,7 +5,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/integration/httpApi-headers/httpApi-headers.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/integration/java/java.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 // Could not find 'Java', skipping 'Java' tests.

tests/integration/jwt-authorizer/jwt-authorizer.test.js

@@ -6,7 +6,6 @@ import { randomBytes } from 'node:crypto'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import jsonwebtoken from 'jsonwebtoken'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 

tests/integration/kotlin/kotlin.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 // Could not find 'Java', skipping 'Java' tests.

tests/integration/lambda-integration/lambdaIntegration.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const { stringify } = JSON

tests/integration/lambda-invoke/lambdaInvoke.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const { isArray } = Array

tests/integration/lambda-invoke/lambdaInvokeAsync.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/integration/override-authorizer/override-authorizer.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const { stringify } = JSON

tests/integration/python/python-big-json/python-big-json.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { platform } from 'node:os'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 
 // skipping 'Python 3' tests on Windows for now.

tests/integration/python/python3/python3.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { platform } from 'node:os'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../../_testHelpers/index.js'
 
 // skipping 'Python 3' tests on Windows for now.

tests/integration/ruby/ruby.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 // Could not find 'Ruby', skipping 'Ruby' tests.

tests/integration/scala/scala.test.js

@@ -1,7 +1,6 @@
 import assert from 'node:assert'
 import { resolve } from 'node:path'
 import { env } from 'node:process'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 // Could not find 'Java', skipping 'Java' tests.

tests/integration/uncategorized/uncategorized.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../_testHelpers/index.js'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))

tests/mochaGlobalSetup.cjs

@@ -1,7 +1,15 @@
 const { env } = require('node:process')
 
 // can be sync or async
-exports.mochaGlobalSetup = function mochaGlobalSetup() {
+exports.mochaGlobalSetup = async function mochaGlobalSetup() {
   //   env.RUN_TEST_AGAINST_AWS = env.AWS_ENDPOINT != null
   env.TEST_BASE_URL = env.AWS_ENDPOINT || 'http://localhost:3000'
+
+  // install global fetch
+  // TODO remove `node-fetch` module and use global built-in with node.js v18+ support
+  if (globalThis.fetch === undefined) {
+    const { default: fetch, Headers } = await import('node-fetch')
+    globalThis.fetch = fetch
+    globalThis.Headers = Headers
+  }
 }

tests/scenario/apollo-server-lambda.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { dirname, resolve } from 'node:path'
 import { env } from 'node:process'
 import { fileURLToPath } from 'node:url'
-import fetch from 'node-fetch'
 import { joinUrl, setup, teardown } from '../integration/_testHelpers/index.js'
 import installNpmModules from '../installNpmModules.js'
 

tests/scenario/docker-in-docker.test.js

@@ -2,7 +2,6 @@ import assert from 'node:assert'
 import { platform } from 'node:os'
 import { env } from 'node:process'
 import { execa } from 'execa'
-import fetch from 'node-fetch'
 import { compressArtifact, joinUrl } from '../integration/_testHelpers/index.js'
 
 // TODO FIXME docker tests currently failing while using node: protocol