Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
l[s] = r
we need to perform the length check before starting the assignment in case we directly mutatel
, as we might otherwise get a corrupted left hand side.. This length check is possibly expensive.if the left hand side is cloned anyway (in case there is more than one reference to the internal vector data) we could just start clone the data and overwrite it. When we then afterwards figure out that the lhs and rhs iterator were not recyclable the result can just be discarded. For now I have just implemented a relatively naive solution.
+
, we can alyways just start the computation. It one if the iterators is not yet exhausted after iterating, we can then throw an error and discard the result.TODOs: