Added keyword for ingress create and delete #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-nubolab
changed the title
m-wcislo
reviewed
Sep 30, 2021
| @@ -3,4 +3,4 @@ command_line = -m unittest discover | |||
| source = | |||
| src/ | |||
| [report] | |||
| fail_under = 82 | |||
| fail_under = 81 | |||
There was a problem hiding this comment.
We would rather increase the coverage not decrease, it would be best to add unit tests for this change
There was a problem hiding this comment.
Actually it was wrongly committed but this PR will create and delete ingress in a namespace.
There was a problem hiding this comment.
We cannot decrease coverage, please resolve conflicts
m-wcislo
requested changes
Oct 25, 2021
There was a problem hiding this comment.
Complete checklist
- At least one example testcase added in testcases/
- Library Documentation regenerated according to Generate docs
- All new testcases tagged as prerelease along other tags to exclude it from execution until released on PyPI
- Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI
| @@ -3,4 +3,4 @@ command_line = -m unittest discover | |||
| source = | |||
| src/ | |||
| [report] | |||
| fail_under = 82 | |||
| fail_under = 81 | |||
There was a problem hiding this comment.
We cannot decrease coverage, please resolve conflicts
| @@ -23,6 +23,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| - Keyword for list daemonset [#50](https://github.com/devopsspiral/KubeLibrary/pull/50) by [@satish-nubolab](https://github.com/satish-nubolab) | |||
| - Keyword for CustomObjectsApi [#54](https://github.com/devopsspiral/KubeLibrary/pull/54) by [@mika-b](https://github.com/mika-b) | |||
| - Example tests for Ambassador CRDs [#63](https://github.com/devopsspiral/KubeLibrary/pull/63) by [@Nilsty](https://github.com/Nilsty) | |||
| - Example tests for Ambassador CRDs [#63](https://github.com/devopsspiral/KubeLibrary/pull/63) by [@Nilsty](https://github.com/Nilsty) | |||
There was a problem hiding this comment.
Update changelog after release v0.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new keywords for Ingress create, edit and delete.
#95