Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting fix for cert validation bug #61

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Conversation

m-wcislo
Copy link
Collaborator

@m-wcislo m-wcislo commented Mar 11, 2021

Cert validation could be disabled only for single api client. Changed the way clients are defined so it is smarter.

Before merge following needs to be applied:

  • PR entry added in CHANGELOG.md in In progress section
  • Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI
fail_under = 67

@m-wcislo m-wcislo requested a review from Nilsty March 11, 2021 20:28
@Nilsty Nilsty merged commit 6446a9b into master Mar 12, 2021
@Nilsty Nilsty deleted the fix-validate-certificate branch March 12, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants