add kw to query Kubernetes API health endpoints #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-wcislo
reviewed
Mar 1, 2021
There was a problem hiding this comment.
Thanks for your contribution. There is already PR addressing #21, but you could add your extra functionality (endpoint and verbosity handling on top of it) + for example support for individual tests and exclusions as in https://kubernetes.io/docs/reference/using-api/health-checks/?
If that is is ok with you we could merge it after #40 is merged.
mika-b
force-pushed
the
add-kw-for-health-api
branch
from
98b3585 to
45355b2
Compare
mika-b
force-pushed
the
add-kw-for-health-api
branch
from
45355b2 to
40341da
Compare
|
Rebased and updated. Hows that? |
Nilsty
requested changes
Mar 5, 2021
There was a problem hiding this comment.
Super nice! I really like those templated test cases.
Would you mind adding this PR to the changelog?
https://github.com/devopsspiral/KubeLibrary/blob/master/CHANGELOG.md
|
Changelog update. |
|
Also added prerelease tag. |
Nilsty
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #21