Health check #37
Closed
Health check #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nilsty
requested changes
Feb 19, 2021
src/KubeLibrary/KubeLibrary.py
Outdated
| @@ -3,6 +3,8 @@ | |||
| import ssl | |||
| import urllib3 | |||
| from kubernetes import client, config | |||
| import requests | |||
There was a problem hiding this comment.
requests is not needed, see the comment below.
There was a problem hiding this comment.
request module removed.
src/KubeLibrary/KubeLibrary.py
Outdated
| @@ -11,27 +13,19 @@ | |||
|
|
|||
| class KubeLibrary(object): | |||
| """KubeLibrary is a Robot Framework test library for Kubernetes. | |||
|
|
|||
There was a problem hiding this comment.
please leave those empty lines as they improve readability.
| *** Keywords *** | ||
| Healthcheck | ||
| ${output}= Get Healthcheck | ||
| Log \nHealthcheck ${output}: console=True |
There was a problem hiding this comment.
It would be nice if your example keyword could also verify if all checks have passed with ok.
There was a problem hiding this comment.
Evaluated the response and verified if all checks have passed with ok.
|
Incorporated all review comments. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21 Add keyword for cluster health check