Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added small improvements. #101

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

MarcinMaciaszek
Copy link
Contributor

Small improvements in library

I have updated setup.py reqs and library scope. SUITE scope make much more sense for this library.

Fixes #no_issue

Before merge following needs to be applied:

  • At least one example testcase added in testcases/ --
  • Library Documentation regenerated according to Generate docs
  • PR entry added in CHANGELOG.md in In progress section
  • All new testcases tagged as prerelease along other tags to exclude it from execution until released on PyPI
  • Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI
fail_under = 67

@MarcinMaciaszek MarcinMaciaszek force-pushed the small-improvements branch 12 times, most recently from c6cf223 to 16c0e10 Compare December 7, 2021 11:07
@MarcinMaciaszek
Copy link
Contributor Author

@Nilsty @m-wcislo could you please review this PR?

Copy link
Collaborator

@m-wcislo m-wcislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I really like making it less messy! I've added some small comments.

.circleci/config.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/KubeLibrary/version.py Outdated Show resolved Hide resolved
@m-wcislo m-wcislo merged commit fb41933 into devopsspiral:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants