#1530 added maven settings password decryption #1583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added org.codehaus.plexus sec-dispatcher dependency added org.codehaus.plexus cipher dependency added MavenSettingsUtil added MavenSettingsUtilTest and resources
github-actions
bot
added
comp:core
Team_CobiGen_Templates
2 tasks
maybeec
requested changes
Sep 21, 2022
Zylesto
approved these changes
Sep 22, 2022
replaced authToken with password added basic username and password authentication
made sure that only template-set.xml files get returned as download links added new template-set.xml to ConfigurationConstants added a valid template-set.xml example to test resource files removed extra outputs (non template-set.xml) from test assertions added classifier to Nexus2Response renamed retrieveDownloadUrls to retrieveTemplateSetXmlDownloadURLs
fixed credentials not being used fixed too many httpclient calls being used added new test for a failed basic authentication added new test for a failed token authentication enabled bad url test
removed JsonMappingException because it is already being handled by JsonProcessingException
adjusted log messages (converted to debug, made factory process messages more transparent) converted RestSearchResponseException status code from string to integer
|
|
Zylesto
approved these changes
Sep 28, 2022
replaced exception strings with constants added retrieveRestSearchApiTargetLink method adjusted SearchResponseException with dynamic message adjusted tests to check for exception types and message content
|
This PR is not needed anymore as all of the changes were added to #1585 already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses/Fixes #1530 #1517.
Implements
@devonfw/cobigen