Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of tray icon when there are unread notifications #156

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Change color of tray icon when there are unread notifications #156

merged 4 commits into from
Jul 1, 2019

Conversation

dkniffin
Copy link
Contributor

@dkniffin dkniffin commented Jul 1, 2019

No unread notifications:
Screen Shot 2019-06-30 at 9 34 51 PM

At least one unread notification:
Screen Shot 2019-06-30 at 9 35 17 PM

Related to #90

@dkniffin
Copy link
Contributor Author

dkniffin commented Jul 1, 2019

I haven't tested this on anything except mac. Not sure if that matters for merging this or not.

@brunolemos
Copy link
Member

This is great @dkniffin, thanks!

@brunolemos
Copy link
Member

brunolemos commented Jul 1, 2019

I pushed a commit to remove the hook from the reduce, because that breaks one of the hooks rules and causes this error: 6479650

image

@brunolemos brunolemos merged commit 6a6e1e3 into devhubapp:master Jul 1, 2019
brunolemos added a commit that referenced this pull request Jul 2, 2019
brunolemos added a commit that referenced this pull request Jul 3, 2019
@dkniffin
Copy link
Contributor Author

dkniffin commented Jul 9, 2019

@brunolemos Mind pushing another release soon? I'd like to start using this without having to run the app locally

@brunolemos
Copy link
Member

@dkniffin I’m trying to get one more thing together in the same release, but you can run yarn workspace @devhub/desktop build that it will create a production app exactly the same as the one I’d release.

brunolemos added a commit that referenced this pull request Jul 11, 2019
@brunolemos brunolemos added this to the v0.93.0 milestone Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants