Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to tipg #55

Merged
merged 18 commits into from
Mar 16, 2023
Merged

move to tipg #55

merged 18 commits into from
Mar 16, 2023

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Feb 20, 2023

closes #53

This PR does:

  • remove eoapi.features and replace eoapi.vector with a TiPG based application
  • update pre-commit (use ruff)

To Do

  • update integration tests
  • write custom SQL function
    • STAC collection or searchid as MVT
    • STAC collection or searchid count for each tile request as MVT

directory="",
loader=jinja2.ChoiceLoader(
[
jinja2.PackageLoader(__package__, "templates"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-02-20 at 6 50 26 PM

)
await register_collection_catalog(
app,
schemas=["public"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard coding tipg db settings (using TIPG_DB_SCHEMAS won't have any influence) I'm not sure about this

tables=db_settings.tables,
function_schemas=["pg_temp"],
# functions=db_settings.functions,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that is complex here is that we can't pass the custom SQL directory via variable but we will have to use TIPG_CUSTOM_SQL_DIRECTORY environment

https://github.com/developmentseed/tipg/blob/main/tipg/settings.py#L161-L170

@vincentsarago
Copy link
Member Author

🥳 I had a lot difficulties to make the tests past because of the addition of the public table.

Basically we are adding the table after we start the vector service, but then the public.my_data is not found within tipg catalog (because we added it after the start of the service). We have /refresh debug endpoint but sadly this will only refresh the catalog for the worker it was ran on, so it doesn't guaranty that all the worker will be up to date 😬

Maybe we should open an issue in tipg to add a force_refresh=True query-parameter option which will refresh the catalog on each request (cc @bitner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace vector and feature service by Tipg
2 participants