This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Use __construct instead of class name for constructor #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future versions of PHP will not allow use of class name as constructor.
|
@metadaddy This is kind of a big deal! Please merge! |
|
#59 looks like the most complete PR for this request |
|
Agreed, @aaronbauman can we get that merged? |
|
@aaronbauman What can I do to get this merged? |
|
Sorry, @aaronbauman I thought you were with salesforce. @dcarroll maybe is? |
|
can be closed due to the merging of #59 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future versions of PHP will not allow use of class name as constructor.