Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update extract logic for using newer 7zz/7zzs/7zr.exe binaries #139

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

mmaietta
Copy link
Collaborator

Conditionally adds -snld flag based on detecting SZA binary path to have suffix 7za.
Maintains backward compatibility of app-builder-bin's extract artifact logic between versions of 7za (old) and 7zz/7zzs/7zr.exe (new)
Ref: https://sourceforge.net/p/sevenzip/bugs/2356/

Tested with artifacts in related PR develar/7zip-bin#27

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 93976be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-builder-bin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta marked this pull request as ready for review September 24, 2024 07:53
@mmaietta mmaietta merged commit 128737e into master Sep 24, 2024
2 checks passed
@mmaietta mmaietta deleted the update-for-newer-7zz-binaries branch September 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant