This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Bump all the things #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
reviewed
Oct 17, 2021
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-all.zip | |||
There was a problem hiding this comment.
Shouldn't here be distribution type bin instead of all? To make Gradle downloading slightly faster on CI and reduce cache size?
There was a problem hiding this comment.
Because this is a plugin project, all is generally more reasonable since we need IntelliJ to be able to navigate the gradle APIs.
BraisGabin
approved these changes
Oct 17, 2021
chao2zhang
approved these changes
Oct 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's keep the compiler plugins up to date. Specifically I'm bumping to:
And Gradle to 7.2