Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove all legacy handlers #795

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Mar 24, 2022

Description

Closes: #566

This PR removes all legacy handlers since it is no longer used.

See: cosmos/cosmos-sdk#7517


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Mar 24, 2022
@dadamu dadamu changed the title Remove all legacy handlers feat: remove all legacy handlers Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #795 (ecfc47e) into master (73a6816) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          76       76           
  Lines        6503     6503           
=======================================
  Hits         5284     5284           
  Misses        977      977           
  Partials      242      242           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d6ddf...ecfc47e. Read the comment docs.

@dadamu dadamu requested review from leobragaz and RiccardoM March 24, 2022 05:46
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Mar 24, 2022
@mergify mergify bot merged commit 3039589 into master Mar 24, 2022
@mergify mergify bot deleted the paul/remove-legacy-handler branch March 24, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all the legacy handlers
3 participants