feat: relationships module #750

RiccardoM · 2022-02-22T10:17:47Z

Description

This PR implements the new x/relationships module. This module contains all the user blocks and relationships actions that were previously present inside the x/profiles module.

Some changes have been done to the logic of relationships and user blocks, particularly:

it is not required anymore to have a Desmos profile in order to block another user
it is not required anymore that both parties have a Desmos profile in order to establish a relationship
blocking a user inside the subspace 0 will not lead to the user being blocked on all subspaces anymore. The subspace with id 0 now only identifies the x/profiles subspace. Users blocked there won't be able to send DTag transfer requests to other users or perform other actions from within the x/profiles module that involve the blocker.

Depends-On: #753

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <[email protected]>

…subspace-module-adr-impl � Conflicts: � x/profiles/types/models_chain_links.pb.go

Signed-off-by: Riccardo Montagnin <[email protected]>

… files Signed-off-by: Riccardo Montagnin <[email protected]>

Signed-off-by: Riccardo Montagnin <[email protected]>

…ps module Signed-off-by: Riccardo Montagnin <[email protected]>

…relationships-module � Conflicts: � app/app.go � app/desmos/cmd/chainlink/create_json_test.go � app/params/weights.go � client/docs/swagger-ui/swagger.yaml � proto/desmos/profiles/v1beta1/query_relationships.proto � proto/desmos/profiles/v2/models_relationships.proto � proto/desmos/profiles/v3/genesis.proto � proto/desmos/profiles/v3/msg_server.proto � proto/desmos/profiles/v3/msgs_dtag_requests.proto � proto/desmos/profiles/v3/msgs_profile.proto � proto/desmos/profiles/v3/msgs_relationships.proto � proto/desmos/profiles/v3/query.proto � proto/desmos/profiles/v3/query_relationships.proto � proto/desmos/relationships/v1/query.proto � proto/desmos/subspaces/v1/genesis.proto � proto/desmos/subspaces/v1/msgs.proto � proto/desmos/subspaces/v1/query.proto � x/profiles/client/cli/cli_test.go � x/profiles/keeper/genesis_test.go � x/profiles/keeper/grpc_query.go � x/profiles/keeper/grpc_query_test.go � x/profiles/keeper/invariants.go � x/profiles/keeper/invariants_test.go � x/profiles/keeper/keeper.go � x/profiles/keeper/migrations.go � x/profiles/keeper/msg_server_blocks.go � x/profiles/keeper/msg_server_relationships.go � x/profiles/keeper/msg_server_relationships_test.go � x/profiles/legacy/v2/models_relationships.pb.go � x/profiles/legacy/v3/store.go � x/profiles/module.go � x/profiles/simulation/decoder.go � x/profiles/simulation/decoder_test.go � x/profiles/simulation/genesis.go � x/profiles/simulation/operations.go � x/profiles/types/genesis.go � x/profiles/types/genesis.pb.go � x/profiles/types/genesis_test.go � x/profiles/types/keys.go � x/profiles/types/msg_server.pb.go � x/profiles/types/msgs_dtag_requests.pb.go � x/profiles/types/msgs_profile.pb.go � x/profiles/types/query.pb.go � x/profiles/types/query.pb.gw.go � x/relationships/client/cli/tx.go � x/relationships/keeper/blocks.go � x/relationships/keeper/blocks_test.go � x/relationships/keeper/msg_server_test.go � x/relationships/keeper/relationships.go � x/relationships/simulation/operations_relationships.go � x/relationships/types/models.go � x/relationships/types/msg_server.pb.go � x/relationships/types/msgs.go � x/relationships/types/query.pb.go � x/subspaces/client/cli/cli_test.go � x/subspaces/client/cli/query.go � x/subspaces/client/cli/tx.go � x/subspaces/handler.go � x/subspaces/keeper/alias_functions.go � x/subspaces/keeper/genesis.go � x/subspaces/keeper/genesis_test.go � x/subspaces/keeper/groups.go � x/subspaces/keeper/groups_test.go � x/subspaces/keeper/grpc_query.go � x/subspaces/keeper/grpc_query_test.go � x/subspaces/keeper/invariants.go � x/subspaces/keeper/invariants_test.go � x/subspaces/keeper/keeper.go � x/subspaces/keeper/msg_server.go � x/subspaces/keeper/msg_server_test.go � x/subspaces/keeper/permissions.go � x/subspaces/keeper/permissions_test.go � x/subspaces/keeper/subspaces.go � x/subspaces/keeper/subspaces_test.go � x/subspaces/simulation/decoder.go � x/subspaces/simulation/decoder_test.go � x/subspaces/simulation/genesis.go � x/subspaces/simulation/operations.go � x/subspaces/simulation/operations_groups.go � x/subspaces/simulation/operations_permissions.go � x/subspaces/simulation/operations_subspaces.go � x/subspaces/simulation/utils.go � x/subspaces/types/codec.go � x/subspaces/types/events.go � x/subspaces/types/genesis.go � x/subspaces/types/genesis.pb.go � x/subspaces/types/genesis_test.go � x/subspaces/types/keys.go � x/subspaces/types/msgs.go � x/subspaces/types/msgs.pb.go � x/subspaces/types/msgs_test.go � x/subspaces/types/permissions.go � x/subspaces/types/query.go � x/subspaces/types/query.pb.go � x/subspaces/types/query.pb.gw.go Signed-off-by: Riccardo Montagnin <[email protected]>

Signed-off-by: Riccardo Montagnin <[email protected]>

…space is deleted Signed-off-by: Riccardo Montagnin <[email protected]>

leobragaz

The overall looks good but there are some tests failing because of the hooks.

Signed-off-by: Riccardo Montagnin <[email protected]>

…into riccardo/relationships-module � Conflicts: � x/subspaces/simulation/genesis.go

Signed-off-by: Riccardo Montagnin <[email protected]>

…relationships-module � Conflicts: � app/sim_test.go � x/subspaces/simulation/genesis.go

Signed-off-by: Riccardo Montagnin <[email protected]>

leobragaz · 2022-03-01T09:01:59Z

app/sim_test.go

@@ -231,7 +229,6 @@ func TestAppImportExport(t *testing.T) {

 		{app.keys[subspacestypes.StoreKey], newApp.keys[subspacestypes.StoreKey], [][]byte{}},
 		{app.keys[profilestypes.StoreKey], newApp.keys[profilestypes.StoreKey], [][]byte{}},
-		{app.keys[relationshipstypes.StoreKey], newApp.keys[relationshipstypes.StoreKey], [][]byte{}},


why we remove this?

dadamu

Overall is good to me. It is ready to go once the problem @bragaz proposed is solved.

## Description This PR adds missing events inside the `x/profiles` modukes Closes: #721 Depends-On: #750 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

RiccardoM added 25 commits January 14, 2022 10:29

added the Proto definitions of the subspaces types and messages

10efacc

Signed-off-by: Riccardo Montagnin <[email protected]>

improved the Proto file definition

32f7981

Signed-off-by: Riccardo Montagnin <[email protected]>

improved the Proto file definition

9293ae2

Signed-off-by: Riccardo Montagnin <[email protected]>

started working on the implementation of the message server methods

ed8e474

Signed-off-by: Riccardo Montagnin <[email protected]>

more work on the handling of messages

b0f4f61

Signed-off-by: Riccardo Montagnin <[email protected]>

added unit tests for subspaces and permissions

fca2aa9

Signed-off-by: Riccardo Montagnin <[email protected]>

completed the keeper package tests

e08f3b3

Signed-off-by: Riccardo Montagnin <[email protected]>

completed tests for the types package

3fe18f4

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

5a3362f

…subspace-module-adr-impl � Conflicts: � x/profiles/types/models_chain_links.pb.go

added the CLI tests

735a1fd

Signed-off-by: Riccardo Montagnin <[email protected]>

added the integration tests

a4d22bd

Signed-off-by: Riccardo Montagnin <[email protected]>

added changeset entry

78a5499

Signed-off-by: Riccardo Montagnin <[email protected]>

updated x/profiles to use the correct type for subspaces ids

8233131

Signed-off-by: Riccardo Montagnin <[email protected]>

added initial subspaces id to the subspaces genesis

10e2a71

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed simulation tests

c7006d3

Signed-off-by: Riccardo Montagnin <[email protected]>

added changeset entry for x/profiles

2b04da8

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed formatting

d28fef6

Signed-off-by: Riccardo Montagnin <[email protected]>

added migration for both modules

5a557c3

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed lint

7d91aed

Signed-off-by: Riccardo Montagnin <[email protected]>

chore: updated Proto packages to match real versions

4c62789

Signed-off-by: Riccardo Montagnin <[email protected]>

chore: renamed subspace fields to subspace_id inside x/profiles Proto…

1615ab3

… files Signed-off-by: Riccardo Montagnin <[email protected]>

small lint

5dd2122

Signed-off-by: Riccardo Montagnin <[email protected]>

chore: replaced all expErr with shouldErr

e422c23

Signed-off-by: Riccardo Montagnin <[email protected]>

moved all the relationships-related things into the new x/relationshi…

4fc9328

…ps module Signed-off-by: Riccardo Montagnin <[email protected]>

github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Feb 22, 2022

RiccardoM and others added 2 commits February 22, 2022 10:18

Updated Swagger definition

d53accf

fixed compilation errors

a85a164

Signed-off-by: Riccardo Montagnin <[email protected]>

RiccardoM added 8 commits February 25, 2022 12:05

fixed Docker

d26d36c

Signed-off-by: Riccardo Montagnin <[email protected]>

updated make-build

654fe44

Signed-off-by: Riccardo Montagnin <[email protected]>

trying to fix build-linux

9d2b3b9

Signed-off-by: Riccardo Montagnin <[email protected]>

trying to fix build-linux

447a887

Signed-off-by: Riccardo Montagnin <[email protected]>

trying to fix build-linux

ffd76a3

Signed-off-by: Riccardo Montagnin <[email protected]>

updated Proto field numberings

355b3a7

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed handler comment

7ee6fb7

Signed-off-by: Riccardo Montagnin <[email protected]>

added the subspace hook to delete relationships and blocks when a sub…

cda19c2

…space is deleted Signed-off-by: Riccardo Montagnin <[email protected]>

leobragaz approved these changes Feb 28, 2022

View reviewed changes

leobragaz reviewed Feb 28, 2022

View reviewed changes

RiccardoM added 2 commits February 28, 2022 10:46

fixed hooks tests

f91d6bc

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge branch 'riccardo/fix-actions' of github.com:desmos-labs/desmos …

a46f4c3

…into riccardo/relationships-module � Conflicts: � x/subspaces/simulation/genesis.go

github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD labels Feb 28, 2022

fixed simulation tests

c62adf3

Signed-off-by: Riccardo Montagnin <[email protected]>

RiccardoM mentioned this pull request Feb 28, 2022

fix: add missing events to x/profiles #759

Merged

19 tasks

RiccardoM added 2 commits February 28, 2022 12:01

fixed simulation tests

82e9d2b

Signed-off-by: Riccardo Montagnin <[email protected]>

added changeset entry

78635ba

Signed-off-by: Riccardo Montagnin <[email protected]>

RiccardoM mentioned this pull request Feb 28, 2022

fix: improve x/profiles gRPC queries #760

Merged

19 tasks

RiccardoM added 2 commits March 1, 2022 08:36

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

8c0a088

…relationships-module � Conflicts: � app/sim_test.go � x/subspaces/simulation/genesis.go

merged master

69cb74d

Signed-off-by: Riccardo Montagnin <[email protected]>

github-actions bot removed kind/build Related to the build of the project kind/ci Improve the CI/CD labels Mar 1, 2022

RiccardoM requested a review from dadamu March 1, 2022 07:42

leobragaz reviewed Mar 1, 2022

View reviewed changes

dadamu approved these changes Mar 1, 2022

View reviewed changes

Merge branch 'master' into riccardo/relationships-module

69f3334

mergify bot merged commit 8998def into master Mar 1, 2022

mergify bot deleted the riccardo/relationships-module branch March 1, 2022 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: relationships module #750

feat: relationships module #750

RiccardoM commented Feb 22, 2022 •

edited

Loading

leobragaz left a comment

leobragaz Mar 1, 2022

dadamu left a comment

feat: relationships module #750

feat: relationships module #750

Conversation

RiccardoM commented Feb 22, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

leobragaz left a comment

Choose a reason for hiding this comment

leobragaz Mar 1, 2022

Choose a reason for hiding this comment

dadamu left a comment

Choose a reason for hiding this comment

RiccardoM commented Feb 22, 2022 •

edited

Loading