Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the post message cap to 500 characters #70

Merged
merged 3 commits into from
Jan 11, 2020

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 8, 2020

Description

This PR allows to cap the post message length to 500 characters, fixing #67

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM RiccardoM added kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module Status:WIP labels Jan 8, 2020
@RiccardoM RiccardoM added this to the v0.2.0 milestone Jan 8, 2020
@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #70 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   75.36%   75.65%   +0.28%     
==========================================
  Files          17       17              
  Lines         759      768       +9     
==========================================
+ Hits          572      581       +9     
  Misses        176      176              
  Partials       11       11
Impacted Files Coverage Δ
x/posts/internal/types/msgs.go 100% <100%> (ø) ⬆️
x/posts/internal/types/post.go 95.65% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0574ed...a092352. Read the comment docs.

@RiccardoM RiccardoM marked this pull request as ready for review January 8, 2020 09:25
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be all ok, i've check even if the vars in fmt.Sprintf() matches the correct places.

@RiccardoM
Copy link
Contributor Author

I'd like to have @kwunyeung reviewing this PR too if possible 😄

Copy link
Contributor

@kwunyeung kwunyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwunyeung kwunyeung merged commit b142b75 into master Jan 11, 2020
@RiccardoM RiccardoM deleted the riccardo/limit-posts-message-length branch January 12, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants