-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for hex address in chain link #688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
==========================================
- Coverage 84.23% 79.10% -5.14%
==========================================
Files 91 52 -39
Lines 6624 4201 -2423
==========================================
- Hits 5580 3323 -2257
+ Misses 833 711 -122
+ Partials 211 167 -44
Continue to review full report at Codecov.
|
be8f2ae
to
c3d959d
Compare
Co-authored-by: Leonardo Bragagnolo <[email protected]>
Co-authored-by: Leonardo Bragagnolo <[email protected]>
Co-authored-by: Leonardo Bragagnolo <[email protected]>
Co-authored-by: Leonardo Bragagnolo <[email protected]>
Co-authored-by: Leonardo Bragagnolo <[email protected]>
Co-authored-by: Leonardo Bragagnolo <[email protected]>
Co-authored-by: Leonardo Bragagnolo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready now 👍
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
…ort-hex-address-chain-link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes but otherwise LGTM
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Description
Closes: #685
This PR is the implementation of #685. It extends the support to the hex address like ETH.
Note: Rename PR to add support for eth address since eth address is generated in the other way.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change